Improve destination param #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amegias
force-pushed
the
improve-scripts
branch
from
fde3f8b to
40adbd2
Compare
WanaldinoTelefonica
approved these changes
Feb 19, 2024
pbartolome
approved these changes
Feb 20, 2024
|
🎉 This PR is included in version 29.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
We found some issues executing tests due to the destination param looks working different due to the XC tools version.
See:
https://teams.microsoft.com/l/message/19:[email protected]/1697557532308?tenantId=9744600e-3e04-492e-baa1-25ec245c6f10&groupId=992881f8-bbab-4891-8c17-ffe99ba6f43b&parentMessageId=1697532771278&teamName=Apps%20Team&channelName=iOS&createdTime=1697557532308
🚧 How do we do it?
I've updated the destination value to ensure it will work with the right device.
🧪 How can I verify this?
It just affects to tests so if tests pass...