fix(AccessibilityIdentifiers): IOS-9694 - New struct for common Ids #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanegon
requested review from
a team,
idenjoe and
Gomay88
and removed request for
a team
idenjoe
approved these changes
Feb 1, 2024
Gomay88
approved these changes
Feb 2, 2024
|
🎉 This PR is included in version 29.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-9694
🥅 What's the goal?
Add a default ID for the list chevron image.
🚧 How do we do it?
We have brought from iphoneapp a struct called
DefaultAccessibilityIdentifierwhere we have different properties to compose the identifier following theFeature,SectionandElementTypedefined as constants. This way we prepare mistica to unify the IDs with Android following the different ids configured in Figma, like listsTo accomplish this issue we have created the enum
ListAccessibilityIdentifierswhich has differentDefaultAccessibilityIdentifierconstants, so we can use the chevron to set as default in the SwiftUI CellNavigationPreset.swift and UIKit version /NavigationPresetView.swift⚾️ Extra Ball ⚾️
I created the FeedbackAccessibilityIdentifiers.swift to leave it prepared and check thath everything is well done
🧪 How can I verify this?
AccesibilityIdsMistica.mov