Make server::router not move-able. #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routes added to the router have a raw reference to the router itself. When a router is moved, even though all the members are moved, the raw references would not update themselves, which makes them dangling. Downgrade router from move-able to non-move-able, and make routing_context store a unique_ptr to router instead of an object. This way, moving the routing_context would not end up creating a new router, so references stored in the routes would remain valid.
kar8uncle
changed the title
kar8uncle
commented
Jan 2, 2025
| @@ -14,7 +14,8 @@ using namespace malloy::server; | |||
|
|
|||
| routing_context::routing_context(config cfg) : | |||
| m_cfg{std::move(cfg)}, | |||
| m_router{m_cfg.logger != nullptr ? m_cfg.logger->clone("router") : nullptr, m_cfg.agent_string} | |||
| m_router{new server::router{m_cfg.logger != nullptr ? m_cfg.logger->clone("router") : nullptr, | |||
There was a problem hiding this comment.
This constructor is private 😢 Cannot use make_unique.
|
Thanks! I'll need a bit more time to dig into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As explained in #130. With this change I no longer see the crash I was seeing.
I did not try building with the examples and tests. Feel free to make changes to make those pass.
Commit Message