-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Update debian to bookworm in v17.0 and v16.0 #578
Conversation
Rebase for solving conflicts, and better to start just with one version for minimizing problems. Always one problem at a time. |
cbcbed4
to
3e4a1ee
Compare
21fa4bd
to
0f4abd1
Compare
Please @pedrobaeza , review this changes. I will open other PR in order to dockerize wkhtmltopdf if necessary |
tests/__init__.py
Outdated
def test_dotd_ge_16(self): | ||
"""Test environment with common ``*.d`` directories. | ||
Only for versions greater or equal to 16""" | ||
for sub_env in matrix(odoo_skip={"11.0", "12.0", "13.0", "14.0", "15.0"}): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid duplicating all these stuff. You can do inside the same test several loops, letting the common ones together, and just including the differences in different loops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding new commits amending code from this same PR makes the review harder. Better to cleanup the commits that add the original code.
af8bdbf
to
2f4ee18
Compare
-Updating wkhtmltopdf to a bookworm compatible version
-Updating wkhtmltopdf to a bookworm compatible version
a93821b
to
977217a
Compare
-Adding tests scaffoldings for odoo_version >= 16 in test_dotd and test_dependencies
4a74f96
to
57bb34f
Compare
CC @Tecnativa TT45983