[IMP] Update debian to bookworm in v17.0 and v16.0 #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase for solving conflicts, and better to start just with one version for minimizing problems. Always one problem at a time. |
josep-tecnativa
force-pushed
the
imp-debian-bookworm
branch
4 times, most recently
from
cbcbed4
to
3e4a1ee
Compare
ap-wtioit
reviewed
Nov 15, 2023
josep-tecnativa
force-pushed
the
imp-debian-bookworm
branch
9 times, most recently
from
21fa4bd
to
0f4abd1
Compare
|
Please @pedrobaeza , review this changes. I will open other PR in order to dockerize wkhtmltopdf if necessary |
pedrobaeza
reviewed
Nov 16, 2023
pedrobaeza
reviewed
Nov 16, 2023
tests/__init__.py
Outdated
| def test_dotd_ge_16(self): | ||
| """Test environment with common ``*.d`` directories. | ||
| Only for versions greater or equal to 16""" | ||
| for sub_env in matrix(odoo_skip={"11.0", "12.0", "13.0", "14.0", "15.0"}): |
There was a problem hiding this comment.
Please avoid duplicating all these stuff. You can do inside the same test several loops, letting the common ones together, and just including the differences in different loops.
There was a problem hiding this comment.
Adding new commits amending code from this same PR makes the review harder. Better to cleanup the commits that add the original code.
josep-tecnativa
force-pushed
the
imp-debian-bookworm
branch
2 times, most recently
from
af8bdbf
to
2f4ee18
Compare
-Updating wkhtmltopdf to a bookworm compatible version
-Updating wkhtmltopdf to a bookworm compatible version
josep-tecnativa
force-pushed
the
imp-debian-bookworm
branch
3 times, most recently
from
a93821b
to
977217a
Compare
-Adding tests scaffoldings for odoo_version >= 16 in test_dotd and test_dependencies
josep-tecnativa
force-pushed
the
imp-debian-bookworm
branch
2 times, most recently
from
4a74f96
to
57bb34f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Tecnativa TT45983