header removal #293
Merged
header removal #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanTheMan827
force-pushed
the
mainline
branch
from
5ca3b1d to
f25b03e
Compare
Hakchi2 CE will remove (external) header or any SNES rom, independently of extension. It is important because sometimes a header is added manually by the user in order for him to be able to apply a patch that requires a headered rom. Said situation may result in a headered .sfc rom, and Hakchi2 CE currently will not remove such header (the header would be removed only if the extension were .smc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Hakchi2 CE will only remove the headers of .smc files, but there are cases when ,fig or .sfc files can also contain a header. For example, a user may manually add a header to a rom in order to apply a patch that requires a headered rom. The result could be a headered .sfc, and Hakchi2 CE would not remove its header.