Migrate empty_state_view xml/view to Jetpack Compose #11463
Conversation
|
cc @opusforlife2 PTAL. Let me know if other code reviewers should be in the review loop as well. |
|
|
|
||
| import org.schabi.newpipe.BaseFragment; | ||
| import org.schabi.newpipe.R; | ||
| import org.schabi.newpipe.ui.emptystate.EmptyStateUtil; | ||
|
|
||
| public class EmptyFragment extends BaseFragment { |
There was a problem hiding this comment.
The entire fragment could be implemented using Compose directly, see https://developer.android.com/reference/kotlin/androidx/fragment/compose/package-summary#(androidx.fragment.app.Fragment).content(kotlin.Function0)
There was a problem hiding this comment.
OK. This PR is to have a single purpose. Since applying this API requires firstly migrating EmptyFragment to kotlin, I can start another PR purely for the migration without mixing it into one.
| @@ -27,7 +31,7 @@ | |||
| public class CommentsFragment extends BaseListInfoFragment<CommentsInfoItem, CommentsInfo> { | |||
There was a problem hiding this comment.
I've already migrated this fragment to Compose in a separate PR, so I don't think this particular change will be needed.
There was a problem hiding this comment.
Good to know. This can wait for your PR.
What is it?
Description of the changes in your PR
As part of the rewrite effort, this PR migrates the
empty_state_viewxml and view to Jetpack Compose. It contains the followingEmptyStateComposableand specs used different fragments.EmptyStateUtilto provide java -> kotlin interpolation methods.MutableState<EmptyStateSpec>to trigger recompositation upon ui state changes.Before/After Screenshots/Screen Record
More screenshot is coming before PR commition.
Fixes the following issue(s)
Rewrite Issue 1: The Jetpack Compose Migration #11198
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence