Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load no sundamage biomes and dimension from datapack #1212

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

Cheaterpaul
Copy link
Member

@Cheaterpaul Cheaterpaul commented May 9, 2023

Biomes, dimensions and levels can now be marked as sun damage / no sundamage biomes.
This can be done by creating the following file data/<modid>/vampirism/no_sun_damage.json

{
  "replace": false,
  "biomes": [
    "#vampirism:has_faction/vampire"
  ],
  "dimensions": [
    "minecraft:the_nether",
    "minecraft:the_end"
  ],
  "levels": {
    "damage": [
      "minecraft:overworld"
    ],
    "no_damage": [
      "vampirism:vampire_level"
    ]
  }
}

replace: if true replaces all previous no_sun_damage.json files
biomes: define biomes in which vampires should not take sundamage (biome id or biome tag)
dimension: define dimension type in which vampire should not take sundamage (dimension type id or dimension type tag)
levels: mark levels as sundamage / no sundamage levels

All sundamage settings can be modified by using the api or the config options which will override the data settings

@Cheaterpaul Cheaterpaul added the enhancement Any minor tweak that can be introduced in minor releases label May 14, 2023
@Cheaterpaul Cheaterpaul force-pushed the feature/sundamage_data branch 2 times, most recently from 72fccc8 to 43d54f1 Compare September 19, 2023 12:22
@Cheaterpaul Cheaterpaul marked this pull request as ready for review September 19, 2023 12:29
@Cheaterpaul Cheaterpaul merged commit 04146e1 into dev Sep 19, 2023
2 checks passed
@Cheaterpaul Cheaterpaul deleted the feature/sundamage_data branch September 24, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any minor tweak that can be introduced in minor releases
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant