-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Convertibles from datapack #1211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm more in favor of "never change a running system", but this is nice to have, if it is properly tested and documented. |
Cheaterpaul
added
the
enhancement
Any minor tweak that can be introduced in minor releases
label
May 14, 2023
Cheaterpaul
force-pushed
the
feature/convertible_datapack
branch
from
September 15, 2023 14:39
f62396c
to
fdc5f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convertibles can now be registered through datapacks. Registering convertibles over the api is still supported, but will always be overridden by datapack changes.
All json files in
data/<modid>/vampirism/convertibles
are loaded.The entity id is resolved byfoldername:filename
.E.g the file
data/<modid>/vampirism/convertibles/minecraft/fox.json
defines theminecraft:fox
entity as convertible.The handler and overlay fields are optional. If no handler is specified it uses the
vampirism:default
handler. In case of no overlay, no overlay will be rendered.Available converting handler are:
converted_type
By default some attributes are increased when converting an entity. These are knockback_resistance, max_health, attack_damage and movement_speed.
They can be manually configured