-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix [#65] 세부사항 수정 #68
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cc949fd
[Feat] #65 - 회원가입 약관동의 분기처리 이슈 해결
Heyjooo a8e80d3
[Feat] #65 - 마이페이지 스크롤 네비게이션 이슈 해결
Heyjooo 39359e6
[Feat] #65 - skip 버튼 누를 때도 user 정보 저장
Heyjooo df0f8cb
[Feat] #65 - 소셜로그인 뷰모델 수정
Heyjooo e656f4c
[Fea] #65 - get일 때 httpBody nil로 설정
Heyjooo 538e806
[Feat] #65 - BackGesture 이슈 해결
Heyjooo ee30f8e
[Feat] #65 - Back Gesture 삭제
Heyjooo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ import UIKit | |
|
||
import SnapKit | ||
|
||
final class MyPageAccountInfoViewController: UIViewController { | ||
final class MyPageAccountInfoViewController: UIViewController, UIGestureRecognizerDelegate { | ||
|
||
// MARK: - Properties | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 주어진 코드 패치의 간단한 코드 리뷰를 도와드리겠습니다. 버그 위험성과/또는 개선 제안 사항을 언급하겠습니다:
지금까지 코드 리뷰였습니다. 추가적인 정보나 질문이 있다면 알려주세요! |
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주어진 코드에 대한 간단한 코드 리뷰입니다.
변경된 부분:
extension UIViewController
에서statusBarHeight
라는 계산된 프로퍼티가 추가되었습니다. 이 프로퍼티는 상태 표시줄의 높이를 반환합니다.UINavigationController
extension이 삭제되었습니다.버그 위험 및 개선 제안:
일반적으로 코드 리뷰에는 다음과 같은 몇 가지 체크 포인트가 있을 수 있습니다:
다만, 주어진 코드 패치가 개별 프로젝트의 일부분이기 때문에 상황에 따라 다른 리뷰 포인트가 필요할 수 있습니다.