-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix [#168] 로딩뷰 QA 이슈 수정 #169
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,8 +12,7 @@ import Lottie | |
final class DontBeLoadingView: UIView { | ||
|
||
private var loadingText: String = "" | ||
private var loadingTexts = [StringLiterals.Loading.loadingMessage1, | ||
StringLiterals.Loading.loadingMessage2, | ||
private var loadingTexts = [StringLiterals.Loading.loadingMessage2, | ||
StringLiterals.Loading.loadingMessage3, | ||
StringLiterals.Loading.loadingMessage4, | ||
StringLiterals.Loading.loadingMessage5, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 코드는 "loadingTexts" 배열에서 "loadingMessage1" 아이템을 제거하고 "loadingMessage2" 아이템을 첫 번째 요소로 추가했습니다. 이 변경은 의도된 것인지 확인해야 합니다. 이에 대한 주석이나 변경 로그가 필요할 수 있습니다. 또한, "loadingTexts" 배열 초기화 중에 콤마(,)를 유지하는 일관성이 있어야 합니다. 개선 제안:
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,20 +148,27 @@ final class DontBeTabBarController: UITabBarController { | |
extension DontBeTabBarController: UITabBarControllerDelegate { | ||
|
||
func tabBarController(_ tabBarController: UITabBarController, didSelect viewController: UIViewController) { | ||
if selectedIndex == 1 { | ||
self.selectedIndex = 0 | ||
} | ||
|
||
if selectedIndex == 2 { | ||
self.tabBar.items?[2].image = ImageLiterals.TabBar.icnNotificationRead | ||
} | ||
|
||
if beforeIndex == 2 && self.selectedIndex == 0 { | ||
showLoadingView() | ||
if beforeIndex == 2 { | ||
if self.selectedIndex == 0 { | ||
showLoadingView() | ||
print("여기는 \(self.selectedIndex)") | ||
} | ||
} | ||
|
||
if beforeIndex == 3 { | ||
if self.selectedIndex == 0 { | ||
showLoadingView() | ||
print("여기는 \(self.selectedIndex)") | ||
} | ||
} | ||
|
||
if beforeIndex == 3 && self.selectedIndex == 0 { | ||
showLoadingView() | ||
if selectedIndex == 1 { | ||
self.selectedIndex = 0 | ||
hideLoadingView() | ||
} | ||
|
||
if let selectedViewController = tabBarController.selectedViewController { | ||
|
@@ -215,8 +222,14 @@ extension DontBeTabBarController { | |
loadingView.show() | ||
|
||
DispatchQueue.main.asyncAfter(deadline: .now() + 1.4) { | ||
loadingView.hide { | ||
} | ||
loadingView.hide() | ||
} | ||
} | ||
|
||
private func hideLoadingView() { | ||
let loadingView = DontBeLoadingView() | ||
DispatchQueue.main.async { | ||
loadingView.hide() | ||
} | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 코드 리뷰:
개선 제안:
이러한 변경 사항을 적용하면 코드의 가독성과 효율성을 향상시킬 수 있습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 코드 리뷰에서는 다음과 같은 사항을 고려할 수 있습니다:
이외의 디테일한 부분은 여러 컨텍스트와 팀 업무 환경에 따라 달라질 수 있습니다.