-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#150] 프로필 사진 변경 API 연동 및 모든 프로필 사진 부분 적용 #152
Changes from all commits
fb99995
c118109
4df823b
668ebd3
3f6b99c
f19b881
fa6d9c5
65ee4db
0aecf76
9f6c1d0
83cda7b
43e76de
9ed0e96
e3a22f9
dc28493
e08a6a4
e6f5673
7ec00c4
8848708
90d0ca4
099795f
425ab4d
0ec0453
2ddfd71
6761fd9
f25f94a
5eb528e
4a97983
9b6e631
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1491,10 +1491,12 @@ | |
GENERATE_INFOPLIST_FILE = YES; | ||
INFOPLIST_FILE = "DontBe-iOS/Global/Resources/Info.plist"; | ||
INFOPLIST_KEY_CFBundleDisplayName = "Don't Be"; | ||
INFOPLIST_KEY_NSPhotoLibraryUsageDescription = "게시글이나 프로필을 변경할 때 사용합니다."; | ||
INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents = YES; | ||
INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen; | ||
INFOPLIST_KEY_UISupportedInterfaceOrientations = UIInterfaceOrientationPortrait; | ||
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown"; | ||
INFOPLIST_KEY_UIUserInterfaceStyle = Light; | ||
IPHONEOS_DEPLOYMENT_TARGET = 15.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
|
@@ -1526,10 +1528,12 @@ | |
GENERATE_INFOPLIST_FILE = YES; | ||
INFOPLIST_FILE = "DontBe-iOS/Global/Resources/Info.plist"; | ||
INFOPLIST_KEY_CFBundleDisplayName = "Don't Be"; | ||
INFOPLIST_KEY_NSPhotoLibraryUsageDescription = "게시글이나 프로필을 변경할 때 사용합니다."; | ||
INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents = YES; | ||
INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen; | ||
INFOPLIST_KEY_UISupportedInterfaceOrientations = UIInterfaceOrientationPortrait; | ||
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown"; | ||
INFOPLIST_KEY_UIUserInterfaceStyle = Light; | ||
IPHONEOS_DEPLOYMENT_TARGET = 15.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 주석 없이 두 부분이 거의 동일하므로, 코드 리뷰 중 수정이 필요한 부분은 다음과 같습니다:
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
// | ||
|
||
import Foundation | ||
import UIKit | ||
|
||
// MARK: - UserProfileRequestDTO | ||
|
||
|
@@ -15,3 +16,10 @@ struct UserProfileRequestDTO: Encodable { | |
let member_intro: String | ||
let profile_url: String | ||
} | ||
|
||
struct EditUserProfileRequestDTO { | ||
let nickname: String | ||
let is_alarm_allowed: Bool | ||
let member_intro: String | ||
let profile_image: UIImage | ||
Comment on lines
+22
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3 |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 리뷰:
개선 제안: