Feat [#105] 404 페이지 구현 및 답글에서 프로필 클릭시 유저페이지로 이동 및 유저 투명도에 따른 글쓰기 분기처리 #110
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "img_404.png", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } | ||
|
There was a problem hiding this comment. 해당 코드는 Xcode에서 사용하는 이미지 정보를 정의하는 JSON 형식의 파일입니다. 버그 위험은 존재하지 않습니다.
|
||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| // | ||
| // ErrorViewController.swift | ||
| // DontBe-iOS | ||
| // | ||
| // Created by 변희주 on 1/18/24. | ||
| // | ||
|
|
||
| import UIKit | ||
|
|
||
| import SnapKit | ||
|
|
||
| final class ErrorViewController: UIViewController { | ||
|
|
||
| // MARK: - Properties | ||
|
|
||
| // MARK: - UI Components | ||
|
|
||
| private let errorImage: UIImageView = { | ||
| let emptyImage = UIImageView() | ||
| emptyImage.image = ImageLiterals.Common.img404 | ||
| return emptyImage | ||
| }() | ||
|
|
||
| private let errorTitle: UILabel = { | ||
| let emptyTitle = UILabel() | ||
| emptyTitle.text = StringLiterals.Network.errorMessage | ||
| emptyTitle.textColor = .donBlack | ||
| emptyTitle.font = .font(.body1) | ||
| emptyTitle.setTextWithLineHeight(text: emptyTitle.text, lineHeight: 22.adjusted, alignment: .center) | ||
| emptyTitle.numberOfLines = 2 | ||
| return emptyTitle | ||
| }() | ||
|
|
||
| private let homeButton = CustomButton(title: StringLiterals.Button.goHome, backColor: .donBlack, titleColor: .donWhite) | ||
|
|
||
| // MARK: - Life Cycles | ||
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
|
|
||
| setUI() | ||
| setHierarchy() | ||
| setLayout() | ||
| setAddTarget() | ||
| } | ||
| } | ||
|
|
||
|
|
||
| // MARK: - Extensions | ||
|
|
||
| extension ErrorViewController { | ||
| private func setUI() { | ||
| self.view.backgroundColor = .donWhite | ||
| } | ||
|
|
||
| private func setHierarchy() { | ||
| self.view.addSubviews(errorImage, | ||
| errorTitle, | ||
| homeButton) | ||
| } | ||
|
|
||
| private func setLayout() { | ||
| errorImage.snp.makeConstraints { | ||
| $0.top.equalToSuperview().inset(statusBarHeight + 182.adjustedH) | ||
| $0.centerX.equalToSuperview() | ||
| $0.width.equalTo(255.adjusted) | ||
| $0.height.equalTo(150.adjusted) | ||
| } | ||
|
|
||
| errorTitle.snp.makeConstraints { | ||
| $0.top.equalTo(errorImage.snp.bottom).offset(34.adjustedH) | ||
| $0.centerX.equalToSuperview() | ||
| } | ||
|
|
||
| homeButton.snp.makeConstraints { | ||
| $0.bottom.equalTo(self.view.safeAreaLayoutGuide).inset(29.adjusted) | ||
| $0.centerX.equalToSuperview() | ||
| } | ||
| } | ||
|
|
||
| private func setAddTarget() { | ||
| self.homeButton.addTarget(self, action: #selector(homeButtonTapped), for: .touchUpInside) | ||
| } | ||
|
|
||
| @objc | ||
| private func homeButtonTapped() { | ||
| if let sceneDelegate = UIApplication.shared.connectedScenes.first?.delegate as? SceneDelegate { | ||
| DispatchQueue.main.async { | ||
| let viewController = DontBeTabBarController() | ||
| viewController.selectedIndex = 0 | ||
| if let selectedViewController = viewController.selectedViewController { | ||
| viewController.applyFontColorAttributes(to: selectedViewController.tabBarItem, isSelected: true) | ||
| } | ||
| sceneDelegate.window?.rootViewController = UINavigationController(rootViewController: viewController) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
There was a problem hiding this comment. 이 코드 패치는 주요 개선 제안:
버그/위험 사항:
추가 제안:
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주어진 코드 패치의 코드 리뷰를 해드리겠습니다.
ErrorViewController.swift가 소스로 추가됩니다.404이라는 이름의 새로운 그룹이 생성되며,ErrorViewController.swift파일이 해당 그룹에 포함됩니다.404그룹이Presentation그룹 내에 추가됩니다.ErrorViewController.swift in Sources파일 참조가 추가됩니다.버그나 개선점을 파악하기 위해서는 전체 소스 코드와 어떤 프레임워크/도구를 사용하는지 알아야 합니다. 따라서 여기서 설명드릴 수 있는 점은 제한적입니다. 이 코드 패치가 올바르게 작동하려면 다음을 고려해야 할 수 있습니다:
이외에도 세부적인 내용은 제공되지 않아서 더 자세한 코드 분석이 어렵습니다. 전체 코드를 주실 경우 보다 정확하고 구체적인 피드백을 제공할 수 있습니다.