Auto speed depending on vision assistance toggle #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionCommand fork to determine our speed if not using vision? Possible plan B?
Rongrrz
changed the title
aschokking
reviewed
Apr 3, 2024
| @@ -54,6 +55,8 @@ public DriveSubsystem(PIDManagerFactory pidFactory, PropertyFactory pf, | |||
| pf.createPersistentProperty("Suggested Autonomous Maximum Speed", 3.0); | |||
| suggestedAutonomousExtremeSpeed = | |||
| pf.createPersistentProperty("Suggested Autonomous EXTREME Speed", 5.0); | |||
There was a problem hiding this comment.
⭐ ⭐ ⭐ there are actually 2 auto speeds (normal and extreme), and I think your override should impact both of them, so we'll want another property for the no vision extreme speed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Asana task URL:
Whats changing?
Questions/notes for reviewers
A better way would probably to just go into the drive to note command and check get the maximum speed every execution (so that we don't have to reboot every single time), but then like that's probably going to be affecting other things... or how about a command that extends off of that does that in every execution? Hmm.
How this was tested