Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bread and butter 4 note auto: no longer goes back to shoot if no note in robot #283

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Rongrrz
Copy link
Contributor

@Rongrrz Rongrrz commented Mar 30, 2024

Why are we doing this?

To save time in case if any teammates had been bribed to intentionally grief us in auto for the purpose of not letting us get into worlds which we definitely will win if we get in there. Or maybe collector just did some oopsie oopsies (._.).

Asana task URL:

What's changing?

The bread and butter 4 note mid subwoofer auto has been changed.

Questions/notes for reviewers

How to resolve a importing b and b importing a issues?

How this was tested

  • unit tests added
  • tested on robot

@Rongrrz Rongrrz requested a review from a team as a code owner March 30, 2024 18:55
@aschokking aschokking changed the title 4 note auto no longer goes back and shoot if no note Bread and butter 4 note auto: no longer goes back to shoot if no note in robot Mar 31, 2024
@Rongrrz Rongrrz requested a review from aschokking April 3, 2024 01:47
@aschokking aschokking removed their request for review April 8, 2024 13:18
@aschokking
Copy link
Contributor

We never had a chance to try this on the real robot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants