친구 검색 시 팔로우 / 팔로잉 버튼이 보이도록 구현 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangbaam
reviewed
Feb 29, 2024
Comment on lines
159
to
188
| if (item.isFollowing) { | ||
| Box(modifier = Modifier | ||
| .clip(RoundedCornerShape(10.dp)) | ||
| .background(Color(0xFFE4E4E4)) | ||
| .clickable { | ||
| viewModel.unFollow(item.user) | ||
| } | ||
| .padding(horizontal = 12.dp, vertical = 5.dp)) { | ||
| Text( | ||
| text = "팔로잉", | ||
| style = WalkieTypography.Body2, | ||
| ) | ||
| } | ||
| } else { | ||
| Box(modifier = Modifier | ||
| .clip(RoundedCornerShape(10.dp)) | ||
| .background(WalkieColor.Primary) | ||
| .clickable { | ||
| viewModel.follow(item.user) | ||
| } | ||
| .padding(horizontal = 12.dp, vertical = 5.dp)) { | ||
| Text( | ||
| text = "팔로우", | ||
| style = WalkieTypography.Body2.copy( | ||
| Color.White | ||
| ), | ||
| ) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
색상과 문자열 빼곤 컴포넌트의 모양과 액션이 동일하기 때문에 별도의 컴포저블로 분리하는게 어떨까 싶습니다 😎
Suggested change
| if (item.isFollowing) { | |
| Box(modifier = Modifier | |
| .clip(RoundedCornerShape(10.dp)) | |
| .background(Color(0xFFE4E4E4)) | |
| .clickable { | |
| viewModel.unFollow(item.user) | |
| } | |
| .padding(horizontal = 12.dp, vertical = 5.dp)) { | |
| Text( | |
| text = "팔로잉", | |
| style = WalkieTypography.Body2, | |
| ) | |
| } | |
| } else { | |
| Box(modifier = Modifier | |
| .clip(RoundedCornerShape(10.dp)) | |
| .background(WalkieColor.Primary) | |
| .clickable { | |
| viewModel.follow(item.user) | |
| } | |
| .padding(horizontal = 12.dp, vertical = 5.dp)) { | |
| Text( | |
| text = "팔로우", | |
| style = WalkieTypography.Body2.copy( | |
| Color.White | |
| ), | |
| ) | |
| } | |
| } | |
| } | |
| @Composable | |
| private fun followButton( | |
| modifier: Modifier = Modifier, | |
| isFollowing: Boolean, | |
| onClick: () -> Unit, | |
| ) { | |
| Box( | |
| modifier = modifier | |
| .clip(RoundedCornerShape(10.dp)) | |
| .background(if(isFollowing) Color(0xFFE4E4E4) else WalkieTypography.Body2) | |
| .padding(horizontal = 12.dp, vertical = 6.dp) | |
| .clickable(onClick = onClick), | |
| ) { | |
| Text( | |
| text = if (isFollowing) "팔로잉" else "팔로우", | |
| style = WalkieTypography.Body2, | |
| color = if(isFollowing) Color.Black else Color.White, | |
| ) | |
| } |
There was a problem hiding this comment.
@mangbaam
오예~ 명범님 감사합니다~~! ㅋㅋㅋㅋㅋㅋㅋ
mangbaam
reviewed
Feb 29, 2024
Comment on lines
31
to
33
| style = WalkieTypography.Body2.copy( | ||
| Color.White | ||
| ), |
There was a problem hiding this comment.
아.. 그러네요,,, 감사해요 ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ
There was a problem hiding this comment.
아.. ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 하게되면 알려드릴게요,,, ㅋㅋㅋㅋㅋㅋ
다른 거 KMP로 만들고 있긴한데 파이어베이스쪽만 문제라서
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋ 화이팅입니다 >< 리뷰해주셔서 감사해요~~!!!
yonghanJu
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 작업 내용
🧐 변경된 내용
🥳 동작 화면
🤯 이슈 번호
🥲 비고