Fix [#80] 소식 탭 오류 수정 및 배지 구현, 알림 탭 프로필 이동 구현 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 프로필 터치 시, 나 또는 상대 프로필로 이동 (인기글 선정 및 안내는 제외) - 폴더링 구분 (Page, Activity, Info)
binisnil
approved these changes
Jan 18, 2025
Comment on lines
11
to
13
| final class NotificationPageViewModel { | ||
|
|
||
| } |
There was a problem hiding this comment.
이 부분은 ViewModelType을 채택한 부분과 영역을 분리하기 위해 일부러 두신걸까요?!
There was a problem hiding this comment.
네 맞습니다만, 현재로서는 필요없어 보이네요.
수정하겠습니다.
Comment on lines
+71
to
+75
| segmentedControl.snp.makeConstraints { make in | ||
| make.top.equalTo(safeArea) | ||
| make.horizontalEdges.equalToSuperview() | ||
| make.height.equalTo(48.adjustedH) | ||
| } |
There was a problem hiding this comment.
저는 보통 make -> $0 으로 snp을 적용해주는데, $0으로 진행하게 되면 코드의 의미 전달이 잘 안될까요..??
make나 $0 둘 중 하나로 통일하는게 더 보기 좋을 것 같아요!!!
There was a problem hiding this comment.
아 그렇다면 $0으로 앞으로 진행하겠습니다.
클로저에서 자동완성으로 코드를 빠르게 작성하려다 보니, 그렇게 되었었네요.
Comment on lines
+27
to
+33
| func serialize(_ value: any Encodable) throws -> Data { | ||
| try encoder.encode(value) | ||
| } | ||
|
|
||
| func deserialize<T: Decodable>(_ type: T.Type, from data: Data) throws -> T { | ||
| try decoder.decode(type, from: data) | ||
| } |
There was a problem hiding this comment.
제가 이해한 바로는 UserDefault에 구조체를 저장할 수 있게끔 만들어주신 것 같은데 맞을 까요?! 너무 고생 많으셨습니다!!👍🏻👍🏻
…o fix/#80 # Conflicts: # Wable-iOS/Presentation/TabBar/WableTabBarItem.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👻 PULL REQUEST
🛠️ PR POINT
💡 참고사항
📸 스크린샷
📟 관련 이슈