-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor [#87] 홈 피트 리팩토링 완료 #89
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d92e60d
[Chore] #87 - 밴하기 토스트 추가
binisnil 0b48041
[Chore] #87 - TabBar 수정
binisnil b6dee4b
[Fix] #87 - Popup을 VC로 수정, PopupType 도입
binisnil 79175e6
[Feat] #87 - PopUpViewModel 구현
binisnil 95d6b81
[Fix] #87 - DiffableDataSource로 변경함에 따라 링크 터치이벤트 처리방식 변경
binisnil 8b460d9
[Feat] #87 - HomeView, ViewController 재구성
binisnil d9149a0
[Feat] #87 - HomeFeedDTO가 Hashable을 준수하도록 변경
binisnil 29a77b8
[Fix] #87 - HomeAPI 구현
binisnil 112e919
[Feat] #87 - HomeViewModel 새로 구현
binisnil 28e83ef
[Feat] #87 - 밴하기 기능을 위한 바인딩 추가
binisnil 8eb9b6b
[Chore] #87 - HomeAPI EndPoint추가
binisnil 73f3d21
[Feat] #87 - UIGestureRecognizer Combine Publisher 추가
binisnil f33c643
[Feat] #87 - 글 작성 완료 후 이벤트 설정을 위한 클로저 추가
binisnil 4169f18
[Fix] #87 - 삭제 후 페이징 시 페이징 안되는 문제 해결
binisnil 4fb3fcb
[Fix] #87 - 코드리뷰 반영
binisnil 4fbfb66
[Fix] #87 - 코드리뷰 최종 반영
binisnil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
Wable-iOS/Global/Resources/Assets.xcassets/Toast/toast_ban.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "toast.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+6.92 KB
Wable-iOS/Global/Resources/Assets.xcassets/Toast/toast_ban.imageset/toast.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+14.7 KB
Wable-iOS/Global/Resources/Assets.xcassets/Toast/toast_ban.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24.8 KB
Wable-iOS/Global/Resources/Assets.xcassets/Toast/toast_ban.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호,, 상당히 흥미로운 내용이네요..
UIView 내에서 사용되는 내용이라면, UIView 내부로 감쌀 것 같아요.
extension UIView { }
로 말이죠.그리고 이걸 왜 구현했는지, 무엇을 위해선지가 가장 중요할 것 같아요.
혹시 이유를 알 수 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사진을 탭할 때의 탭 제스처가 필요했는데,, 찾아보니 이렇게 하라는 내용을 봐서요..! 혹시 다른 방법이 있다면 알려주세요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CombineCocoa에 Gesture에 따른 퍼블리셔를 사용할 수 있도록 구현되어 있는 것으로 알고 있어요.
그래서 위 구현사항은 필요가 없을수도 있겠다는 생각이 들었는데요.
이미지뷰라면, userInteraction과 관련된 속성을
true
로 변경하고,@objc
메서드를 선언하여 이미지뷰가 터치되었을 때 어떠한 동작을 할 지 정의할 수 있는 것으로 알고 있습니다.또한 이미지뷰의 터치를 뷰모델에 전달해야 한다면,
@objc
메서드에서 서브젝트의send
를 호출하여 이미지뷰가 터치되었을 때 신호를 전달할 수 있겠네요.