-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #300 - DetailSearchView 상세탐색 기능 2차 구현 #302
Open
Guryss
wants to merge
35
commits into
main
Choose a base branch
from
Feat/#300
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyowon612
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
복잡한 뷰인데 넘 고생 많았습니당 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️Issue
close #300
🌟Motivation
🌟Key Changes
📚 이전뷰에 따른 DetailSearchResultView 분기처리 로직
SearchView에서 넘어온것인지 DetailSearchResultView 내 서치바에서 넘어온 것인지의 여부에 따라 뷰 로직이 다릅니다.
SearchView
: DetailSearch 에서 검색 -> DetailSearchModal dismiss & SearchView에서 DetailSearchResultView pushDetailSearchResultView 내 서치바
: DetailSearch 에서 검색 -> DetailSearchModal dismiss & 기존 뷰에서 데이터 reloadinit 즉 뷰모델을 초기화할 때 같이 매개변수로 뷰타입 열거형을 받을 수 있도록 구현했습니다.
DetailSearchViewModel
에서 이전뷰가 어떤 뷰인지에 따른 노티피케이션을 다르게 줄 수 있도록 구현했습니다.📚재검색 시 모달에 선택한 데이터 남아있도록 구현
DetailSearchResultView 에서 서치바를 클릭하여 검색을 다시 할 때 DetailSearchView에 선택한 데이터가 남아있어야 합니다.
넘겨주는 데이터를 구조체
SearchFilterQuery
로 정의했습니다.DetailSearchViewModel
에서viewDidLoad
시점에 넘어온 데이터를 받아올 수 있도록 했습니다.🌟Simulation
ScreenRecording_11-08-2024.2000-26-29_1.MP4
🌟To Reviewer
도움을 주신 여러분들에게 감사의 말씀을 드려봅니다 ♡
🌟Reference