Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 행복루틴 테마 리스트 조회 #48

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

csb9427
Copy link
Contributor

@csb9427 csb9427 commented Jan 10, 2024

✨ Related Issue

📝 기능 구현 명세

  • 이곳에는 postman 테스트 결과를 넣어주세요
image

🐥 추가적인 언급 사항

사실 아직 테스트 제대로 못해봄 일단 개발해보고 내일 시큐리티랑 같이 테스트하고 코드 수정하겠음 ㅎㅎ;;

@csb9427 csb9427 added the hold review 리뷰 보류 (이전 PR 영향을 받을 때) label Jan 10, 2024
@csb9427 csb9427 added feat 기능 개발 seungbin 승빈 작업 labels Jan 10, 2024
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요! 병합 전 API 테스트 꼭 부탁드려요 :)

@Service
@Transactional(readOnly = true)
@RequiredArgsConstructor
public class HappinessRoutineServiceImpl implements HappinessRoutineService{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 스타일의 통일을 위해서 Service와 { 사이에 한 칸 띄어쓰기 부탁드려요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헛 감사합니다

@csb9427 csb9427 removed the hold review 리뷰 보류 (이전 PR 영향을 받을 때) label Jan 11, 2024
@csb9427 csb9427 merged commit 2f540d5 into develop Jan 11, 2024
1 check passed
@csb9427 csb9427 deleted the feature/#19-all-theme-get-api branch January 11, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 기능 개발 seungbin 승빈 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 행복루틴 테마 리스트 조회
2 participants