Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 회원 데일리 루틴 달성 #39

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

thguss
Copy link
Member

@thguss thguss commented Jan 10, 2024

✨ Related Issue

📝 기능 구현 명세

image

🐥 추가적인 언급 사항

@thguss thguss added sohyeon 소현 작업 hold review 리뷰 보류 (이전 PR 영향을 받을 때) patch labels Jan 10, 2024
@thguss thguss self-assigned this Jan 10, 2024
Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제는 더 할 말이 없을정도... ㅜㅜ 너무 고생하셨습니다

@thguss thguss removed the hold review 리뷰 보류 (이전 PR 영향을 받을 때) label Jan 10, 2024
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대단합니다..

@@ -1,8 +1,11 @@
package com.soptie.server.memberRoutine.service;

import com.soptie.server.memberRoutine.dto.AchievedMemberDailyRoutineResponse;
import com.soptie.server.memberRoutine.dto.MemberDailyRoutineRequest;
import com.soptie.server.memberRoutine.dto.MemberDailyRoutineResponse;

public interface MemberDailyRoutineService {
MemberDailyRoutineResponse createMemberDailyRoutine(long memberId, MemberDailyRoutineRequest request);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long이 아니고 long인 이유가 있을까요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null을 허용하지 않는 인자이기 때문에 원시형을 사용했습니다!


@Override
@Transactional
public AchievedMemberDailyRoutineResponse achieveMemberDailyRoutine(long memberId, Long routineId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 long인 이유가 궁금합니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위와 같은 이유입니다!

@thguss thguss merged commit 8fe9f2a into develop Jan 10, 2024
1 check passed
@thguss thguss deleted the feature/#38-routine-patch-api branch January 10, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch sohyeon 소현 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 회원 데일리 루틴 달성
3 participants