[hotfix] refactor: 프로필 수정 시 닉네임 중복 체크 로직 수정

Team-Recordy · Jan 13, 2025 · c2c29b1 · c2c29b1
1 parent 6b38b44
commit c2c29b1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/main/java/org/recordy/server/user/service/UserService.java b/src/main/java/org/recordy/server/user/service/UserService.java
@@ -22,7 +22,6 @@ public interface UserService {
     // query
     UserProfile getProfile(long targetUserId, long userId);
     void validateDuplicateNickname(String nickname);
-    void validateDuplicateNickname(User user, String nickname);
     Slice<UserInfo> getSubscribingUserInfos(long userId, Long cursor, int size);
     Slice<UserInfo> getSubscribedUserInfos(long userId, Long cursor, int size);
 }
diff --git a/src/main/java/org/recordy/server/user/service/impl/UserServiceImpl.java b/src/main/java/org/recordy/server/user/service/impl/UserServiceImpl.java
@@ -121,7 +121,9 @@ public void signOut(long userId) {
     public void update(UserUpdate update, long id) {
 
         User user = userRepository.findById(id);
-        validateDuplicateNickname(user, update.nickname());
+        if (!user.getNickname().equals(update.nickname())) {
+            validateDuplicateNickname(update.nickname());
+        }
         user.update(update);
 
         userRepository.save(user);
@@ -151,13 +153,6 @@ public void validateDuplicateNickname(String nickname) {
         }
     }
 
-    @Override
-    public void validateDuplicateNickname(User user, String nickname) {
-        if (!user.getNickname().equals(nickname) && userRepository.existsByNickname(nickname)) {
-            throw new UserException(ErrorMessage.DUPLICATE_NICKNAME);
-        }
-    }
-
     @Override
     public Slice<UserInfo> getSubscribingUserInfos(long userId, Long cursor, int size) {
         return userRepository.findFollowings(userId, cursor, size);