Feat/#144 #147
Open
Feat/#144 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongchandev
reviewed
Jan 5, 2025
|
|
||
| public ResponseData<List<NoticeRes>> getCreated(){ | ||
| Member member = memberAuthenticationHolder.current(); | ||
| List<DivisionMember> divisionMembers = divisionMemberService.getByMember(member); |
There was a problem hiding this comment.
divisionMemberService.getByMember가 호출될 때 마다 getDivision으로 조직을 가져오는데 그냥 DivisionService에서 쿼리로 해결하는게 좋을 듯합니다
hhhello0507
reviewed
Jan 14, 2025
| Notice notice = noticeService.save(generateNoticeReq.toEntity(member)); | ||
|
|
||
| List<Division> divisions = generateNoticeReq.divisions().stream() | ||
| .map(divisionService::getById) |
There was a problem hiding this comment.
division 개수만큼 SQL 조회하는 거 아닌가요?
SQL 한번만 쓸 수 있지 않나여?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.