Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #295

Merged
merged 14 commits into from
May 21, 2024
Merged

Dev #295

merged 14 commits into from
May 21, 2024

Conversation

nathan-vm
Copy link
Collaborator

@nathan-vm nathan-vm commented May 13, 2024

@nathan-vm nathan-vm self-assigned this May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (b88baba) to head (2229795).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   70.19%   70.19%           
=======================================
  Files          44       44           
  Lines        1567     1567           
=======================================
  Hits         1100     1100           
  Misses        467      467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinicvaz
Copy link
Collaborator

@nathan-vm
Dark mode style is weird for missing repositories and generate report button

image
image

@vinicvaz
Copy link
Collaborator

@nathan-vm login and signup page are using only automatic mode style, should we allow users to select which mode to use in these pages too?

@vinicvaz
Copy link
Collaborator

@nathan-vm we should store the selected dark/light mode if the user closes the tab. We don't want to have to change the mode every time we re open the app

@vinicvaz vinicvaz merged commit 94e2a69 into main May 21, 2024
5 checks passed
@vinicvaz vinicvaz deleted the dev branch May 21, 2024 19:06
@nathan-vm nathan-vm restored the dev branch May 21, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants