Bounties #608
Merged
Bounties #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both tree_ascend() and tree_pop() may cause errno to be set/clobbered. As for the latter, we're certainly not interested in the random values that free() etc. may leave in errno. If tree_ascend() fails, its return value takes precedence in determining t->visit_type and the return value, but tree_ascend() also updates t->tree_errno appropriately, which makes sense. But when tree_ascend() succeeds, t->tree_errno should reflect the reason for opendir() failing, which requires that we record errno immediately. Bug bounty: $20
The relevant change in tar/tree.c was made in:
2011-08-25 Tarsnap 1.0.30
c80c7d2
Reported by: Rasmus Villemoes
Bug bounty: $11
This should have been part of:
2008-12-10 Tarsnap 1.0.17
b8dcf6c
There's lots of code between `tree_ret = tree_next()` and this part,
so we can't trust errno.
Reported by: Rasmus Villemoes
Bug bounty: $10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.