Ensure that fread() doesn't set EOF early #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only relevant with libc implementations of fread() which violate the standard. 1) Suppose that fread() reads an entire file into its internal buffer (say, 64kb). 2) Then it returns a smaller value (say, 8192) which we requested. 3) But then it sets the end-of-file indicator because it's loaded the whole file into its internal buffer. *** ^ that's not how fread() is supposed to work. *** 4) Suppose that there's no end-of-line character at the end of the 8192-byte buffer. 5) In that case, we would write '\0' to one past the end of buff. Step 3 violates the standard; fread() should only set the end-of-file if it returns less than we requested. Reported by: Rasmus Villemoes Bug bounty: $5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.