Elastic array wrap around bug #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of modulo wrapping of nsize * 4, the else if block could be taken even though EA->alloc is not really greater than nsize * 4. This can lead to nalloc becoming smaller than nsize, which will result in the buffer to be reallocated to be smaller than the desired nsize.
This commit adds a comment describing the cases handled by the if (nalloc < nsize) block. One such case is the potential wrap around of EA->alloc * 2. Without the comment, it was not clear that the wrap around is properly handled.
Closed
gperciva
reviewed
Oct 20, 2023
| @@ -28,6 +28,12 @@ resize(struct elasticarray * EA, size_t nsize) | |||
| if (EA->alloc < nsize) { | |||
| /* We need to enlarge the buffer. */ | |||
| nalloc = EA->alloc * 2; | |||
| /* | |||
There was a problem hiding this comment.
Sorry, one more nitpick: please add a blank line before this comment.
There was a problem hiding this comment.
Actually, on second thought, never mind.
I don't know why github isn't running the Actions tests on this PR. Based on the documentation I've found, it should be working now. :(
I'm going to make a new PR (from my own account) with these commits, plus that "blank line" nitpick. That's the only guaranteed way I know of getting github Actions to work, and that'll let the review go through faster.
|
This is continued in #596, due to github Actions not running on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits picked up from #592.
Two things: