Add TypeScript type definitions #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
central419
approved these changes
Jan 6, 2021
|
@Tapppi this is useful, could this be merged and published? |
tonyg
reviewed
Feb 7, 2021
| declare namespace AsyncExitHook { | ||
|
|
||
| /** The callback to call when the event handling is finished. */ | ||
| type AsycHookCallback = () => void; |
There was a problem hiding this comment.
Nit: typo here: should be AsyncHookCallback. Use sites will also need to change.
|
Bump. This would be really great to have merged. |
caoer
approved these changes
Jun 11, 2021
|
FYI guys I have made a type definition for this package in the definitely typed repo since the author looks like they abandoned the package. You should now be able to install them with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.