Added polling when getting map layers from RPC #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapLayerVisibilityRequests were sent via RPC too soon when displaying a page with map, because although Oskari responds that it's ready, the layers might not yet be assigned all the way to the internal map state. This is why these visibility requests might fail (race condition).Replaced
getAllLayerswith a polling function that gets the layers from the map's internal state, to assure that the app may proceed in sending the visibility requests.There might be better solutions to this in the future, when this issue gets done: oskariorg/oskari-documentation#58
Also (although probably not relevant to the fix) removed the excessive visibility requests when switching to a page without a map.