Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs with follow-up sections #207

Merged
merged 18 commits into from
Dec 19, 2023
Merged

Fix bugs with follow-up sections #207

merged 18 commits into from
Dec 19, 2023

Conversation

mmoila
Copy link
Collaborator

@mmoila mmoila commented Dec 1, 2023 •
edited
Loading

  • Fix several bugs described in commit messages
  • TODO: Reordering of sub-questions is not working for follow-up sections of type map question (ref. EditMapSubQuestion component)

@mmoila mmoila marked this pull request as ready for review December 1, 2023 16:16
@mmoila mmoila requested a review from ossitammi December 1, 2023 16:16
@mmoila mmoila changed the title Fix a bug with follow-up sections of type map question Fix bugs with follow-up sections Dec 2, 2023
ossitammi
ossitammi requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ossitammi ossitammi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix error when trying to delete a conditional page

server/migrations/1698753080953_conditional-pages-and-sections.ts Outdated Show resolved Hide resolved
@mmoila mmoila requested a review from ossitammi December 19, 2023 12:27
@ossitammi ossitammi merged commit 6a71ac8 into develop Dec 19, 2023
2 checks passed
@ossitammi ossitammi deleted the fix/follow-up-question-bug-fixes branch December 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ossitammi ossitammi Awaiting requested review from ossitammi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmoila @ossitammi