Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter and Prettier added back πŸ”Ž #33

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

JulienTexier
Copy link
Collaborator

✨ What has changed?

This PR adds back Eslint and Prettier and improves it. It also fixes the issues it found.

Copy link

Hi! πŸ‘‹

To ensure a smooth review process, it is recommended to trigger a build (or an update if no native changes have been made since the last build).

You can do so by applying the appropriate label based on your needs:

β€’ πŸ—οΈ 🍏 iOS Build: Select eas-build-ios:dev to trigger a build for iOS
β€’ πŸ—οΈ πŸ€– Android Build: Select eas-build-android:dev to trigger a build for Android
β€’ πŸ—οΈ πŸ“² All Platforms Build: Select eas-build-all:dev to trigger builds for both platforms
β€’ 🌐 EAS Update: Select eas-update to trigger an update (automatically for both platforms)

Note

The update is managed by a custom GitHub action, while the build actions are handled directly via EAS integration.

Once you apply the respective label, the appropriate workflow will be triggered automatically. You can monitor the progress in the Actions tab.

Warning

If you push new commits to your PR branch after selecting a build label, a new build will be triggered automatically.

It is advisable to remove the label once applied and reapply it if necessary; you will likely need to trigger an update instead of a fresh build.

Important

After merging changes into the dev branch, a build will automatically be triggered for both platform using the dev profile.

Therefore, there is no need to manually initiate a build after merging to the dev branch.

Additionally, builds will automatically trigger when promoting changes to test, stag, and prod.

For the prod branch, the build will also be automatically submitted to the app stores.

For more information, refer to the PR Reviews Guide.

@github-actions github-actions bot added fix A label for resolving issues, bugs, or defects in the software maintenance A label for routine maintenance tasks that do not affect user-facing functionality labels Nov 21, 2024
Base automatically changed from feat/web-support to dev November 25, 2024 13:49
@JulienTexier JulienTexier merged commit 1a3cb87 into dev Nov 25, 2024
2 checks passed
@JulienTexier JulienTexier deleted the chore/linter-and-prettier branch November 25, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A label for resolving issues, bugs, or defects in the software maintenance A label for routine maintenance tasks that do not affect user-facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant