Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo 52 and New Architecture πŸŽ‰ #31

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Expo 52 and New Architecture πŸŽ‰ #31

merged 4 commits into from
Nov 25, 2024

Conversation

JulienTexier
Copy link
Collaborator

✨ What has changed?

This PR updates Expo to SDK 52 and enables the New Architecture πŸ₯³

Note

Linter and prettier has been removed at this point and will be added and improved in an upcoming PR.

With the upgrade comes many changes, including:

  • Upgrade of many libraries
  • Separation of configurations like lingui, figmage and prettier to their own files for easier maintenance
  • Use of expo's drop_console instead of Babel plugin transform-remove-console
  • Bottom Sheet component slightly improved (the playground was not working anymore with the latest version of the library)
  • Playground utils file moved to components (it was wrongly in the app folder, so Expo Router considered it a route.
  • NavigationThemeProvider using DefaultTheme to have default fonts if none are added to the project
  • StatusBar moved to expo-status-bar
  • i18n using expo-localization to get system locale
  • Correct text example in store.config.json for English subtitle

Important

There is a known bug with the splashscreen at the moment (the icon is very small). It will be fixed at a later stage. We are monitoring this thread to know more about the issue.

It was in app, so expo-router considered it a screen.
The library update broke the Bottom Sheet playground component, so this fixes it and makes small improvements to it in UI Kit as well.
Copy link

Hi! πŸ‘‹

To ensure a smooth review process, it is recommended to trigger a build (or an update if no native changes have been made since the last build).

You can do so by applying the appropriate label based on your needs:

β€’ πŸ—οΈ 🍏 iOS Build: Select eas-build-ios:dev to trigger a build for iOS
β€’ πŸ—οΈ πŸ€– Android Build: Select eas-build-android:dev to trigger a build for Android
β€’ πŸ—οΈ πŸ“² All Platforms Build: Select eas-build-all:dev to trigger builds for both platforms
β€’ 🌐 EAS Update: Select eas-update to trigger an update (automatically for both platforms)

Note

The update is managed by a custom GitHub action, while the build actions are handled directly via EAS integration.

Once you apply the respective label, the appropriate workflow will be triggered automatically. You can monitor the progress in the Actions tab.

Warning

If you push new commits to your PR branch after selecting a build label, a new build will be triggered automatically.

It is advisable to remove the label once applied and reapply it if necessary; you will likely need to trigger an update instead of a fresh build.

Important

After merging changes into the dev branch, a build will automatically be triggered for both platform using the dev profile.

Therefore, there is no need to manually initiate a build after merging to the dev branch.

Additionally, builds will automatically trigger when promoting changes to test, stag, and prod.

For the prod branch, the build will also be automatically submitted to the app stores.

For more information, refer to the PR Reviews Guide.

@@ -20,22 +20,14 @@ const expoConfig: ExpoConfig = {
name: 'Taito Template',
scheme: config.scheme,
owner: 'taito-united',
version: '1.0.0',
version: '0.0.1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json has it as 0.0.1 and I figured an app created from the template shouldn't start at 1.0.0.

Even React Native is still not there... πŸ˜€

@JulienTexier JulienTexier merged commit 73cfad2 into dev Nov 25, 2024
1 of 3 checks passed
@JulienTexier JulienTexier deleted the feat/expo-52 branch November 25, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants