More ways to open files

[Tyrannicodin]

Adds both double click functionality to thumbnails in the thumbnail grid and an open files shortcut ctrl+shift+O.

[yedpodtrzitko]

Double click makes sense, but Ctrl+Shift+O feels very unusual. Maybe it's because I'm on macOS where the convention is Cmd+↓ (ControlModifier + Key.Key_Down). Using this combo here would make it feel right.

[Tyrannicodin]

I was planning on using ctrl+o but that was the library open shortcut so added the Shift modifier, however that makes sense and I have now changed it.

[CyanVoxel]

TIL that Command-Down Arrow opens the selected item in Finder. If there was an equivalent shortcut for Windows Explorer I would've recommended to use each on their respective platforms, but I can't seem to find one.

[CyanVoxel]

In your description you say that you've added double-clicking to open files, however I don't see anything in the code or in practice that would suggest that.

EDIT: I'm now able to see what the extra click connection was supposed to do, however I would not call this "double-click" to open. Every additional click opens the file an additional time, so triple-clicking the file opens it twice, quadruple-clicking opens it three times, and so on. This also triggers when you make a multi-file selection then return to click the original file with the intention of resetting the selection back to that file. Finally it also seems to break as soon as you interact with the program a bit by searching, which is why I did not see any of this behavior initially.

This may be due to some other changes since #332, but it could also be related to the fact that the connection here is never disconnected. item_thumb has the update_clickable method that's used to do exactly this, where it disconnects the previous clickable and gets assigned a new one. I would recommend mirroring this for the double-click connection.

I would also expect Ctrl/Command + Down Arrow to open all the selected files, however I understand that this was not even a context menu option previously and would likely require additional refactoring (Plus it seems there's now a bug where Ctrl+Click selecting does not update the preview panel).

[yedpodtrzitko]

TIL that Command-Down Arrow opens the selected item in Finder. If there was an equivalent shortcut for Windows Explorer I would've recommended to use each on their respective platforms, but I can't seem to find one.

on Windows it's just Enter, no?

[CyanVoxel]

TIL that Command-Down Arrow opens the selected item in Finder. If there was an equivalent shortcut for Windows Explorer I would've recommended to use each on their respective platforms, but I can't seem to find one.

on Windows it's just Enter, no?

Apparently it is... So simple that Microsoft doesn't even consider it a "shortcut".

In this case I would recommend using the default behavior for each major OS's native file manager (macOS and Windows in this case, with a fallback on one for Linux unless someone can provide more information on that).

[Tyrannicodin]

The shortcut is now based on the main window, so can open multiple files at the same time. It now defaults to ctrl/cmd + Down or Enter on windows.
Double click is now an actual double click instead of the way I did it before.

[yedpodtrzitko]

please fix the pipeline, thanks.

[roboticforest]

In this case I would recommend using the default behavior for each major OS's native file manager (macOS and Windows in this case, with a fallback on one for Linux unless someone can provide more information on that).

Linux file browsers work just like Windows, or at least every version of Ubuntu, Mint, and old versions of RedHat that I've used. The file browsers let you navigate with arrow keys, or by typing the name of the file, then you can just press enter to open what's selected. Or, double-click, of course.