New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up the brush command #348

Open

nlipiarski wants to merge 3 commits into TVPT:sponge-1.12 from nlipiarski:bargs_addition

nlipiarski commented Dec 19, 2019

This pull request provides some clean up to the parsing of the brush command's arguments. The changes include:

Making the brush size argument explicit, but still optional (i.e. shows up in the usage)
Added a dedicated Brush command element for parsing the command line brush arguments
Removing performer consideration from the brush command since we also have the performer command. I think this makes the brush commander more intuitive and also makes the code cleaner.

lipian added 3 commits

December 18, 2019 18:15


          Cleaning up the brush command

bfe5ff0


          Cleaning up the brush parameter parsing

a0cc96e


          Removing unneeded helper function in VoxelSniperCommand

4ffd56b

gabizou added the sponge label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sponge