Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming #1697

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

Add streaming #1697

wants to merge 13 commits into from

Conversation

SamuelWei
Copy link
Collaborator

Fixes #

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

Other information

Copy link

cypress bot commented Dec 12, 2024

PILOS    Run #1614

Run Properties:  status check failed Failed #1614  •  git commit 1ceb6643aa: Add streaming
Project PILOS
Branch Review add-streaming
Run status status check failed Failed #1614
Run duration 04m 27s
Commit git commit 1ceb6643aa: Add streaming
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 26
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎

Tests for review

Failed  RoomsViewMeetings.cy.js • 22 failed tests • Frontend tests

View Output

Test Artifacts
Rooms view meetings > join running meeting Test Replay Screenshots
Rooms view meetings > join running meeting attendance logging Test Replay Screenshots
Rooms view meetings > join running meeting with recording Test Replay Screenshots
Rooms view meetings > join running meeting with recording without video Test Replay Screenshots
Rooms view meetings > join running meeting guests Test Replay Screenshots
Rooms view meetings > join running meeting guests errors Test Replay Screenshots
Rooms view meetings > join running meeting with access code Test Replay Screenshots
Rooms view meetings > join running meeting access code errors Test Replay Screenshots
Rooms view meetings > join running meeting token Test Replay Screenshots
Rooms view meetings > join running meeting token errors Test Replay Screenshots
The first 10 failed tests are shown, see all 22 tests in Cypress Cloud.
Failed  RoomsViewSettingsRoomTypeActions.cy.js • 1 failed test • Frontend tests

View Output

Test Artifacts
Rooms view settings > change room type with expert mode enabled Test Replay Screenshots
Failed  RoomsIndexCreateNewRoom.cy.js • 3 failed tests • Frontend tests

View Output

Test Artifacts
Rooms index create new room > create new room Test Replay Screenshots
Rooms index create new room > create new room errors Test Replay Screenshots
Rooms index create new room > cancel create new room Test Replay Screenshots

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 8.70871% with 304 lines in your changes missing coverage. Please review.

Project coverage is 46.09%. Comparing base (21147ba) to head (1ceb664).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...ces/js/components/RoomTabStreamingConfigButton.vue 0.00% 63 Missing ⚠️
...js/components/AdminStreamingRoomTypeEditButton.vue 0.00% 61 Missing ⚠️
resources/js/views/AdminStreamingSettings.vue 0.00% 58 Missing ⚠️
resources/js/components/RoomTabStreaming.vue 0.00% 46 Missing ⚠️
resources/js/components/AdminOverviewCard.vue 0.00% 23 Missing ⚠️
resources/js/components/RoomJoinButton.vue 9.09% 20 Missing ⚠️
resources/js/components/RoomTabSection.vue 72.72% 9 Missing ⚠️
resources/js/components/FileInput.vue 0.00% 8 Missing ⚠️
resources/js/router.js 0.00% 8 Missing ⚠️
...rces/js/components/AdminStreamingRoomTypeTable.vue 0.00% 5 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (21147ba) and HEAD (1ceb664). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (21147ba) HEAD (1ceb664)
6 3
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #1697       +/-   ##
==============================================
- Coverage      81.01%   46.09%   -34.93%     
==============================================
  Files            361      164      -197     
  Lines           9225     4888     -4337     
  Branches         853      917       +64     
==============================================
- Hits            7474     2253     -5221     
- Misses          1751     2635      +884     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant