Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioning service #1678

Merged
merged 33 commits into from
Jan 14, 2025
Merged

Conversation

pizkaz
Copy link
Contributor

@pizkaz pizkaz commented Dec 9, 2024

Fixes #1636

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Adds a new ProvisioningService providing an API for CRUD operations on models.
  • Adds a new provision:all command consuming a JSON file and using the ProvisioningService to delete existing (if so desired) models and adding new ones according to JSON data.

Other information

@pizkaz pizkaz force-pushed the 1636-provisioning-api branch 8 times, most recently from 980177a to a86d409 Compare December 16, 2024 16:40
@pizkaz pizkaz force-pushed the 1636-provisioning-api branch from 2f01a0a to a906799 Compare January 6, 2025 16:15
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 95.90164% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (13de37b) to head (48d7efe).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
app/Console/Commands/ProvisionCommand.php 86.95% 6 Missing ⚠️
app/Models/Role.php 0.00% 2 Missing ⚠️
app/Models/RoomType.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1678      +/-   ##
=============================================
+ Coverage      81.14%   81.52%   +0.37%     
- Complexity      1355     1410      +55     
=============================================
  Files            362      364       +2     
  Lines           9304     9548     +244     
  Branches         867      867              
=============================================
+ Hits            7550     7784     +234     
- Misses          1754     1764      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pizkaz pizkaz force-pushed the 1636-provisioning-api branch 4 times, most recently from 9828ed1 to ba1e2b8 Compare January 6, 2025 19:14
@pizkaz pizkaz force-pushed the 1636-provisioning-api branch from 9da91de to 352d360 Compare January 14, 2025 11:22
@pizkaz pizkaz force-pushed the 1636-provisioning-api branch from 352d360 to 5c5ba85 Compare January 14, 2025 12:20
@pizkaz pizkaz force-pushed the 1636-provisioning-api branch from bb1a596 to 6dae640 Compare January 14, 2025 14:28
@pizkaz pizkaz force-pushed the 1636-provisioning-api branch from 6dae640 to 2123b76 Compare January 14, 2025 14:31
@SamuelWei SamuelWei merged commit 9f22ab9 into THM-Health:develop Jan 14, 2025
16 checks passed
@SamuelWei SamuelWei added this to the v4.3 milestone Jan 14, 2025
Copy link

cypress bot commented Jan 14, 2025

PILOS    Run #1648

Run Properties:  status check passed Passed #1648  •  git commit 9f22ab91bd: Provisioning service (#1678)
Project PILOS
Branch Review develop
Run status status check passed Passed #1648
Run duration 05m 03s
Commit git commit 9f22ab91bd: Provisioning service (#1678)
Committer PizZaKatZe
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 238
View all changes introduced in this branch ↗︎

@pizkaz pizkaz deleted the 1636-provisioning-api branch January 14, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic artisan command for provisioning
2 participants