This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
bug fix proposal (issue #26) #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea. We can use ODD to restrict the datatype to numerical values. |
raffazizzi
added a commit
that referenced
this pull request
Apr 28, 2014
bug fix proposal (issue #26)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a line which tests if measure_n is falsy. I replaced it with an isNaN test and changed the hyphenation test case to cover measure number 0. This should work with mei2vf for now, but it might be necessary to eventually perform a larger reworking in order to change the measure_n datatype to allow values other than numbers, see #28.