Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] #223 -캐러셀 삭제 시 promotionId로 판단하도록 수정 #224

Merged
merged 1 commit into from
Oct 3, 2024
Merged

[HOTFIX] #223 -캐러셀 삭제 시 promotionId로 판단하도록 수정 #224

merged 1 commit into from
Oct 3, 2024

Conversation

hoonyworld
Copy link
Member

@hoonyworld hoonyworld commented Oct 3, 2024 •
edited
Loading

Related issue 🛠

Work Description ✏️

  • 캐러셀 삭제 시 promotionId 기준으로 처리하도록 수정했습니다.
  • 기존에는 수정/삭제/추가 로직을 수행할 때 캐러셀 번호를 기준으로 삭제 리스트를 정했었습니다.
  • 그런데 수정하려는 promotion의 캐러셀 번호가 바뀌는 경우(ex. 캐러셀 번호: 2->1), 요청 시 삭제하려고 판단했던 캐러셀 번호가 2일 때, 기존에 캐러셀 번호 2에 해당하는 promotion을 삭제해서 수정하려는 promotion이 캐러셀 번호 1로 변하지 못하고 삭제되는 문제가 있었습니다.

Trouble Shooting ⚽️

Related ScreenShot 📷

image image
  • 기존에 앞쪽 캐러셀이 삭제되지 않았던 문제를 해결했습니다!

Uncompleted Tasks 😅

To Reviewers 📢

@hoonyworld hoonyworld self-assigned this Oct 3, 2024
@hoonyworld hoonyworld linked an issue Oct 3, 2024 that may be closed by this pull request
[bug] 캐러셀 삭제 문제 #223
Closed
1 task
@hoonyworld hoonyworld merged commit 2dc6b65 into develop Oct 3, 2024
1 check passed
@hoonyworld hoonyworld deleted the bug/#223 branch October 3, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hoonyworld hoonyworld

Labels
admin HOTFIX🚑 동훈🐻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] 캐러셀 삭제 문제
1 participant
@hoonyworld