Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #164 - 입금여부수정 api 경로 수정 및 dev db 초기화 #165

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

hyerinhwang-sailin
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  • 입금여부수정 api 경로 수정
    이미 requestBody에서 performanceId를 받고 있기에 pathVariable에서 제외했습니다.
    @Operation(summary = "예매자 입금여부 수정 및 웹발신 API", description = "메이커가 자신의 공연에 대한 예매자의 입금여부 정보를 수정한 뒤 예매확정 웹발신을 보내는 PUT API입니다.")
    @PutMapping
    public ResponseEntity<SuccessResponse<Void>> updateTickets(
            @CurrentMember Long memberId,
            @RequestBody TicketUpdateRequest request) {
        ticketService.updateTickets(memberId, request);
        return ResponseEntity.ok(SuccessResponse.of(BookingSuccessCode.TICKET_UPDATE_SUCCESS, null));
    }
  • dev db 초기화
    ddl-auto create로 수정해뒀습니다.

Trouble Shooting ⚽️

Related ScreenShot 📷

image 정상적으로 입금여부 수정되는 것을 확인했습니다.

Uncompleted Tasks 😅

To Reviewers 📢

Copy link
Member

@hoonyworld hoonyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 내용 확인했습니다!

public ResponseEntity<SuccessResponse<Void>> updateTickets(
@CurrentMember Long memberId,
@PathVariable Long performanceId,
@RequestBody TicketUpdateRequest request) {
ticketService.updateTickets(memberId, request);
return ResponseEntity.ok(SuccessResponse.of(BookingSuccessCode.TICKET_UPDATE_SUCCESS, null));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SuccessResponse 클래스에 저희가 만든 정적팩토리메서드가 of와 from이 있습니다.
from은 data를 null로 주도록 설정해 놓았으니, from 메서드를 사용해주시면 더욱 코드가 깔끔해 질 것 같습니다!

@hyerinhwang-sailin hyerinhwang-sailin merged commit 1c57c10 into develop Aug 7, 2024
1 check passed
@hoonyworld hoonyworld deleted the fix/#164 branch August 13, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] 입금여부수정 api 경로 수정 및 dev db 초기화
2 participants