Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] #126 - 프론트 요청 필드 반영 #140

Merged
merged 14 commits into from
Jul 18, 2024
Merged

[refactor] #126 - 프론트 요청 필드 반영 #140

merged 14 commits into from
Jul 18, 2024

Conversation

hoonyworld
Copy link
Member

Related issue 🛠

Work Description ✏️

회원 예매 조회 & 비회원 예매 조회

  • 이미지 url 누락 (posterImage)
  • 전체 가격 누락 (totalPaymentAmount)
  • 예매자 번호 -> 메이커 번호로 변경 필요 (bookerPhoneNumber -> performanceContact)
  • 공연 id 누락 (performanceId)

프론트엔드 파트에서 위의 요청한 사항을 반영하였습니다.

Trouble Shooting ⚽️

Related ScreenShot 📷

Uncompleted Tasks 😅

To Reviewers 📢

@hoonyworld
[#126] refactor(BookingController): 회원 예매 조회시 성공 메시지 변경
5215b0e
@hoonyworld
[#126] refactor(BookingRepository): 쿼리문 추가
1ed827d
@hoonyworld
[#126] refactor(GuestBookingRequest): enum으로 리턴값 변경
8c621c5
@hoonyworld
[#126] refactor(GuestBookingResponse): enum으로 리턴값 변경
31ef65c
@hoonyworld
[#126] chore(GuestBookingRetrieveRequest): 주석 삭제
08dc281
@hoonyworld
[#126] refactor(GuestBookingRetrieveResponse): performanceId, posterI…
522a880 
…mage, totalPaymentAmount 추가
@hoonyworld
[#126] refactor(MemberBookingRetrieveResponse): performanceId, poster…
dc9c16b 
…Image, totalPaymentAmount 추가
@hoonyworld
[#126] refactor(MemberBookingRetrieveService): response에 추가된 필드 리턴하도록…
eb68952 
… 리팩토링
@hoonyworld
[#126] refactor(GuestBookingRetrieveService): response에 추가된 필드 리턴하도록 …
c60ec09 
…리팩토링
@hoonyworld
[#126] refactor(GuestBookingService): displayName이 아닌 열거형으로 리턴하도록 수정
786a015
@hoonyworld
[#126] refactor(MemberBookingRequest): 정적 팩토리 메서드 삭제
f30b21d
@hoonyworld
[#126] refactor(MemberBookingResponse): enum으로 리턴하도록 수정
635cf81
@hoonyworld
[#126] refactor(MemberBookingService): enum으로 리턴하도록 수정
8801b8e
@hoonyworld
[#126] test(GuestBookingServiceConcurrencyTest): DTO에서 수정된 리턴 방법 반영
38f9a3e
@hoonyworld hoonyworld self-assigned this Jul 18, 2024
@hoonyworld hoonyworld linked an issue Jul 18, 2024 that may be closed by this pull request
[refactor] 회원 예매 조회, 비회원 예매 조회에 누락된 필드 추가 #126
Closed
1 task
hyerinhwang-sailin
hyerinhwang-sailin approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@hyerinhwang-sailin hyerinhwang-sailin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ap

@hoonyworld hoonyworld merged commit e1823d7 into develop Jul 18, 2024
1 check passed
@hoonyworld hoonyworld deleted the feat/#126 branch July 19, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyerinhwang-sailin hyerinhwang-sailin hyerinhwang-sailin approved these changes

Assignees

@hoonyworld hoonyworld

Labels
feat feat 동훈🐻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] 회원 예매 조회, 비회원 예매 조회에 누락된 필드 추가
2 participants
@hoonyworld @hyerinhwang-sailin