Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/233 expand m365 log collection #239

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

juliusperez1695
Copy link
Collaborator

Pull Request Template

Description

Addressed changes required following previous pull request for Ticket #233.

Fixes # (issue)

  • Renamed function to 'Get-HawkUserMailItemsAccessed'
  • Added function to export list within 'Hawk.psd1' file
  • Updated the ChangeLog file
  • Changed $UserIDs parameter to $UserPrincipalName
  • Added 'Test-EXOConnection' to BEGIN block within function
  • New folders created for each user where data is to be stored and Out-MultipleFileType '-User' parameter specified
  • File names contain user information
  • 'Get-SimpleUnifiedAuditLog' added for additional output
  • Added Error Handling

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B
  • Unit test of 'Get-HawkUserMailItemsAccessed' function and confirmation of expected output

Checklist:

  • My code follows the style guidelines of Hawk
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jonnybottles jonnybottles self-requested a review January 15, 2025 21:45
@jonnybottles jonnybottles merged commit 6af6ce5 into Development Jan 15, 2025
3 checks passed
@jonnybottles jonnybottles deleted the feature/233-Expand-M365-Log-Collection branch January 15, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants