Migration to hardhat #914
Merged
Migration to hardhat #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .circleci/config.yml # package-lock.json # package.json # test/contracts/Synthetix.js
# Conflicts: # .prettierignore
* Restore ability to read contract sizes * Linter fix
* Remove large circleci resource usage * Only use mainnet forks in CI * Built CI
Codecov Report
@@ Coverage Diff @@
## develop #914 +/- ##
===========================================
- Coverage 97.55% 95.66% -1.90%
===========================================
Files 61 75 +14
Lines 4097 5350 +1253
Branches 524 658 +134
===========================================
+ Hits 3997 5118 +1121
- Misses 100 232 +132
Continue to review full report at Codecov.
|
* Update to develop * Lint fixes * Reduce Collateral contract size for hardhat * Bugfix on publish test * Ignore safety checks in CI prod diff tests * Fix unit tests for hardhat * Import dotenv at hardhat entry point * Bugfix on CI * Bugfix on deploy script * Build CI script
jjgonecrypto
commented
Jan 25, 2021
Comment on lines
+425
to
+426
| // Deterministic account #0 when using `npx hardhat node` | ||
| owner: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266', |
There was a problem hiding this comment.
Can we make this a constant instead of hard-coding it twice?
There was a problem hiding this comment.
Twice? Where's the other instance?
There was a problem hiding this comment.
Ah! I see it. It's in Deployer.js
Fixed
eternauta1337
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WIP 🚧
(not a draft because of ci tests)
Critical TODOs
smockitthat will allow hardhat compilation cc @kfichter[email protected]cc @cgewecke (see Testing solidity-coverage hardhat plugin sc-forks/synthetix#2)hardhat-gas-reporter--use-ovmnot working on compile as@eth-optimism/ovm-toolchainnot supported for hardhat--fail-oversizesupport on compileresource: medium- since reverted to usingresource: large)Nice to have
@eth-optimism/ovm-toolchainneeds upgrading to support hardhatslither-config.jsonhas entrybuidler_cache_directory@nomiclabs/hardhat-truffle5that uses@nomiclabs/[email protected](to prevent truffle emitting event issues Upgrading Web3 >= 1.2.2 trufflesuite/truffle#2688) cc @alcuadrado - should speed up coverage