Xchain pools #1601
Open
Xchain pools #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edge cases identified and will be irioned out tomorrow. but this is most of the structure!
starting to look just a bit ugly, hopefully getting pretty close to the end of the edge cases. we see!
Codecov Report
@@ Coverage Diff @@
## main #1601 +/- ##
===========================================
+ Coverage 62.21% 72.77% +10.56%
===========================================
Files 122 57 -65
Lines 1498 720 -778
Branches 650 236 -414
===========================================
- Hits 932 524 -408
+ Misses 527 167 -360
+ Partials 39 29 -10
Flags with carried forward coverage won't be shown. Click here to find out more. see 65 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* add burn from sender * call burn with target as caller * Add access check * add tests * fix lint * fix lint
next step: pool sync final step: pool config
* add transferCrossChain tests * refund leftover gas and test cleanup * create CrossChainUSDModule
…ix-v3 into xchain-pools
…ix-v3 into xchain-pools
still some failing tests, but in the original branch many of the same test failures existed so going to punt this for later. current focus is implementing the erc7412 support
dbeal-eth
force-pushed
the
xchain-pools
branch
from
df390d3
to
843d554
Compare
probably still a lot of bugs but can probably push up a testnet deployment just to see if everything is gluing together ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.