Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(accounts-db): preallocate account references #324

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

improve(accounts-db): preallocate account references #324

wants to merge 9 commits into from
+249 −161

Conversation

0xNineteen
Copy link
Contributor

@0xNineteen 0xNineteen commented Oct 22, 2024 •
edited
Loading

the way we currently allocate references is pretty sloppy - this PR improves it by using the RecycleFBA to prealloc and manage all our account references:

  • replace allocs with RecycleFBA and have tests pass
  • allow max_n_references to be config through cli
  • run accountsdb fuzz testing (broken on main rn -- sobe checking out cache)
  • re-run benchmarks (would pref to get improved benchmarks pr merged first)

@0xNineteen 0xNineteen changed the title feat(accounts-db): improve reference allocations feat(accounts-db): improve allocations of references Oct 22, 2024
@0xNineteen 0xNineteen changed the title feat(accounts-db): improve allocations of references feat(accounts-db): improve reference allocations Oct 22, 2024
@0xNineteen 0xNineteen changed the title feat(accounts-db): improve reference allocations improve(accounts-db): improve reference allocations Oct 22, 2024
@0xNineteen 0xNineteen changed the title improve(accounts-db): improve reference allocations improve(accounts-db): max reference allocations Oct 22, 2024
@0xNineteen 0xNineteen changed the title improve(accounts-db): max reference allocations improve(accounts-db): preallocate account references Oct 22, 2024
@0xNineteen 0xNineteen mentioned this pull request Oct 22, 2024
Open
@0xNineteen 0xNineteen self-assigned this Oct 22, 2024
@0xNineteen 0xNineteen linked an issue Oct 22, 2024 that may be closed by this pull request
feat(accounts-db): fast snapshot loading #299
Open
@0xNineteen
Copy link
Contributor Author

though the PR is still in draft waiting for a few things on fuzzing + benchmarking, all the logic is implemented so it should be okay to review now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InKryption InKryption Awaiting requested review from InKryption

At least 1 approving review is required to merge this pull request.

Assignees

@0xNineteen 0xNineteen

Labels
None yet
Projects
Sig
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(accounts-db): fast snapshot loading
1 participant
@0xNineteen