Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frame predicate & static states #284

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

MCTian-mi
Copy link
Collaborator

@MCTian-mi MCTian-mi commented Aug 10, 2024

This PR:

  • make susy multis use frames() predicate to enable players using framed pipes in the structure.
  • makes most getCasingState() or alike methods static, probably better in performance.

This has been tested in a dev environment.

Note: there is a ceu issue GregTechCEu/GregTech#2582 where you can remove the frames from pipes in structure without Invalidizating the multis.

Copy link
Member

@bruberu bruberu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, it works now.

@bruberu bruberu merged commit fbcbd9d into SymmetricDevs:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants