Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dispatches on Number via union type #49

Merged
merged 66 commits into from
Nov 1, 2023
Merged

Support dispatches on Number via union type #49

merged 66 commits into from
Nov 1, 2023

Commits on Sep 24, 2023

  1. Define AbstractQuantity <: Number

    @MilesCranmer
    MilesCranmer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    a491992 View commit details
    Browse the repository at this point in the history

  2. Remove defiitions for Missing

    @MilesCranmer
    MilesCranmer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    69f3fd5 View commit details
    Browse the repository at this point in the history

  3. Create AbstractUnionQuantity for multiple abstract quantities

    @MilesCranmer
    MilesCranmer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    a8f25f7 View commit details
    Browse the repository at this point in the history

  4. Create GenericQuantity

    @MilesCranmer
    MilesCranmer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    1410e05 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Update array to allow generic quantities

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    cd1dd2e View commit details
    Browse the repository at this point in the history

  2. Fix some method ambiguities

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    37cb7e6 View commit details
    Browse the repository at this point in the history

  3. Start separate file for ambiguities

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b282ad1 View commit details
    Browse the repository at this point in the history

  4. Fix ambiguity in AbstractDimensions + Quantity

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    66113e2 View commit details
    Browse the repository at this point in the history

  5. Fix ambiguity in powers

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    670ab84 View commit details
    Browse the repository at this point in the history

  6. Fix ambiguity in constructors

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    3e920f9 View commit details
    Browse the repository at this point in the history

  7. Fix ambiguity in getindex

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7491a93 View commit details
    Browse the repository at this point in the history

  8. Move other methods to ambiguities

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    613b2f0 View commit details
    Browse the repository at this point in the history

  9. Rename to disambiguities

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b735283 View commit details
    Browse the repository at this point in the history

  10. Fix ambiguities in promotion rules

    @MilesCranmer
    MilesCranmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    37289c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Merge branch 'main' into union-type

    @gaurav-arya
    gaurav-arya committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    d1414ea View commit details
    Browse the repository at this point in the history

  2. Export generic quantity

    @gaurav-arya
    gaurav-arya committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    810ed86 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Merge branch 'main' into union-type

    @MilesCranmer
    MilesCranmer authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    561ba11 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Add docstrings for generic quantities

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    679057c View commit details
    Browse the repository at this point in the history

  2. More types on missing

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    61b35bf View commit details
    Browse the repository at this point in the history

  3. Prevent invalid dimension conversions

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    042d3eb View commit details
    Browse the repository at this point in the history

  4. Remove old missing test

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    d24d3ac View commit details
    Browse the repository at this point in the history

  5. Fix string test for local version

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    4e8b750 View commit details
    Browse the repository at this point in the history

  6. Fix method hierarchy in constructors

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    f38d630 View commit details
    Browse the repository at this point in the history

  7. Add GenericQuantity tests

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    913228b View commit details
    Browse the repository at this point in the history

  8. Revert "Remove old missing test" 

    This reverts commit d24d3ac.
    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    d68b041 View commit details
    Browse the repository at this point in the history

  9. Fix rounding behavior

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    22d12d0 View commit details
    Browse the repository at this point in the history

  10. Remove overkill promotion function

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    ad2ed1c View commit details
    Browse the repository at this point in the history

  11. Formatting

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    cc519ea View commit details
    Browse the repository at this point in the history

  12. Add missing promotion utility between symbolic and regular

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    72addf4 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'prevent-invalid-conversions' into union-type

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    6b1607c View commit details
    Browse the repository at this point in the history

  14. Make SymbolicDimensions conversion work for union type

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    bca03f2 View commit details
    Browse the repository at this point in the history

  15. Test promotion with both symbolic/non and quantity/generic

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    b6b3245 View commit details
    Browse the repository at this point in the history

  16. Remove unused constructors

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    0567e47 View commit details
    Browse the repository at this point in the history

  17. Formatting

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    1d85f85 View commit details
    Browse the repository at this point in the history

  18. More generic quantity tests

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    9ac4df0 View commit details
    Browse the repository at this point in the history

  19. Add promotion rule for generic numbers

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    b20998b View commit details
    Browse the repository at this point in the history

  20. Add explicit promote_type tests

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    c49c648 View commit details
    Browse the repository at this point in the history

  21. Test conversion to Vector{Any}

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    097cd31 View commit details
    Browse the repository at this point in the history

  22. Merge branch 'main' into union-type

    @MilesCranmer
    MilesCranmer committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    3a73997 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Add docs for union quantity

    @MilesCranmer
    MilesCranmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    f437e6e View commit details
    Browse the repository at this point in the history

  2. Add docs on GenericQuantity

    @MilesCranmer
    MilesCranmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    bc5a9f4 View commit details
    Browse the repository at this point in the history

  3. Clean up docs

    @MilesCranmer
    MilesCranmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    21c9823 View commit details
    Browse the repository at this point in the history

  4. Refactor + and - definitions

    @MilesCranmer
    MilesCranmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    8267824 View commit details
    Browse the repository at this point in the history

  5. More docs

    @MilesCranmer
    MilesCranmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    0c68bb9 View commit details
    Browse the repository at this point in the history

  6. Add more examples

    @MilesCranmer
    MilesCranmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ddd4894 View commit details
    Browse the repository at this point in the history

  7. Add projectile motion example

    @MilesCranmer
    MilesCranmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    452d18c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Split out projectile motion example

    @MilesCranmer
    MilesCranmer committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c495b83 View commit details
    Browse the repository at this point in the history

  2. Add custom dimensions example

    @MilesCranmer
    MilesCranmer committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a65d8ba View commit details
    Browse the repository at this point in the history

  3. Fix documentation number

    @MilesCranmer
    MilesCranmer committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    78b87ef View commit details
    Browse the repository at this point in the history

  4. Expand unittest coverage

    @MilesCranmer
    MilesCranmer committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    aa60738 View commit details
    Browse the repository at this point in the history

  5. Example of custom quantity

    @MilesCranmer
    MilesCranmer committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9ebd6bc View commit details
    Browse the repository at this point in the history

  6. Add example of uconvert on GenericQuantity

    @MilesCranmer
    MilesCranmer committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5248189 View commit details
    Browse the repository at this point in the history

  7. Improve cookie example

    @MilesCranmer
    MilesCranmer committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f8b6e98 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Refactor internal utilities

    @MilesCranmer
    MilesCranmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    3bb9452 View commit details
    Browse the repository at this point in the history

  2. Add compatibility for generic quantities in measurements

    @MilesCranmer
    MilesCranmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    ce9d527 View commit details
    Browse the repository at this point in the history

  3. Add GenericQuantity to array tests

    @MilesCranmer
    MilesCranmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    d02b466 View commit details
    Browse the repository at this point in the history

  4. More GenericQuantity tests

    @MilesCranmer
    MilesCranmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    1f0b39d View commit details
    Browse the repository at this point in the history

  5. Ensure convert(Number, q) is tested

    @MilesCranmer
    MilesCranmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    3faa4ee View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Gaurav Arya <[email protected]>
    @MilesCranmer @gaurav-arya
    MilesCranmer and gaurav-arya authored Oct 28, 2023
    Configuration menu
    Copy the full SHA
    e9e7b8c View commit details
    Browse the repository at this point in the history

  7. Reformat tests

    @MilesCranmer
    MilesCranmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    697037a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. Refactor QuantityArray for GenericQuantity

    @MilesCranmer
    MilesCranmer committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    108aada View commit details
    Browse the repository at this point in the history

  2. Fix documentation build

    @MilesCranmer
    MilesCranmer committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    46abb61 View commit details
    Browse the repository at this point in the history

  3. Clean up quantity array docs

    @MilesCranmer
    MilesCranmer committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    68ff3c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Update name to UnionAbstractQuantity

    @MilesCranmer
    MilesCranmer committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    cc28197 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Update fieldname check from code review

    @MilesCranmer
    MilesCranmer authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a401e86 View commit details
    Browse the repository at this point in the history

  2. Update internal_utils.jl

    @MilesCranmer
    MilesCranmer authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2a1c7ad View commit details
    Browse the repository at this point in the history