Add a cypress test for testing project basic operations: create, edit, delete #3881
Conversation
lorenzo-cavazzi
temporarily deployed
to
ci-renku-3881
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://ci-renku-3881.dev.renku.ch |
lorenzo-cavazzi
temporarily deployed
to
ci-renku-3881
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
ci-renku-3881
GitHub Actions
Inactive
| cy.getDataCy("project-visibility-public").click(); | ||
| cy.getDataCy("project-description-input").type(projectDescription); | ||
| cy.getDataCy("new-project-modal").contains( | ||
| `The URL for this project will be renkulab.io/v2/projects/${username}/${projectPath}` |
There was a problem hiding this comment.
Oh my, oh my, oh my, this is actually hard-coded 🙈 Ouch! 🤕
There was a problem hiding this comment.
There was a problem hiding this comment.
Please remove or comment this test.
There was a problem hiding this comment.
I am checking to ensure we are showing the correct expected URL.
What would be a reasonable alternative here? Perhaps just /${username}/${projectPath}?
There was a problem hiding this comment.
Maybe test that for now and have a comment. Also, that URL WILL be different at the end of this build cycle.
There was a problem hiding this comment.
Oh, true. I made this more resilient to the URL changes and, following your other suggestion on dropping the matcher for new-project-modal, I now match the URL element more precisely 2061f52
lorenzo-cavazzi
temporarily deployed
to
ci-renku-3881
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
ci-renku-3881
GitHub Actions
Inactive
|
@leafty thank you for the review! |
lorenzo-cavazzi
temporarily deployed
to
ci-renku-3881
GitHub Actions
Inactive
| const username = user.username; | ||
| cy.getDataCy("navbar-new-entity").click(); | ||
| cy.getDataCy("navbar-project-new").click(); | ||
| cy.getDataCy("new-project-modal").should("exist"); |
There was a problem hiding this comment.
From the data-cy conversation, I think we should instead check against the presence of a new project form and not a modal. The fact that the form is presented inside a modal is not important and could change (a page, an off canvas, etc.) but there should always be a data-cy=new-project-form element presented to the user.
There was a problem hiding this comment.
Yes, this makes sense! I dropped the use of new-project-modal and match the form instead 2061f52
lorenzo-cavazzi
temporarily deployed
to
ci-renku-3881
GitHub Actions
Inactive
lorenzo-cavazzi
force-pushed
the
lorenzo/cypress-renku-2.0
branch
from
aa689e2 to
cbe29dc
Compare
lorenzo-cavazzi
force-pushed
the
lorenzo/cypress-renku-2.0-project
branch
from
2061f52 to
ac463a6
Compare
See title
/deploy renku-ui=lorenzo/cypress-renku-2.0-data-cy
fix #3880