Fix preconditions and generic types (#1) #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preconditions prevented reading row, column, and channel 0. And the lack of a type constraint on the generic classes were preventing from creating an extension that performed arithmetic operations on the pixel data.
(eg this would fail because yo ucouldn't compare
image[r, c, 0]
to 0; constraining<T>
to aBinaryInteger
should fix it (and it wouldn't even make sense for<T>
to be something weird like aUIView
or something like that):(Fixes #2)