Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[STK-33]: create stack frequency section #31

Merged
merged 6 commits into from
Aug 1, 2023
Merged

feat[STK-33]: create stack frequency section #31

merged 6 commits into from
Aug 1, 2023

Conversation

berteotti
Copy link
Collaborator

@berteotti berteotti commented Jul 13, 2023 •
edited
Loading

Create Stack Frequency section. This PRs add new libs to improve date formats, add popover effect and add calendar components.

Screenshot 2023-07-31 at 11 29 51

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 13, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6c84d99
Status: ✅  Deploy successful!
Preview URL: https://c60e0d6d.stackly-ui.pages.dev
Branch Preview URL: https://feat-stk-33-create-stacktime.stackly-ui.pages.dev

View logs

@berteotti berteotti force-pushed the feat/stk-33-create-stacktimeframefrequency branch from ef105c9 to 01aeec8 Compare July 13, 2023 19:22
@berteotti berteotti marked this pull request as draft July 14, 2023 08:59
@berteotti berteotti force-pushed the feat/stk-33-create-stacktimeframefrequency branch 2 times, most recently from c8a8fe6 to b84bd8b Compare July 14, 2023 16:15
@berteotti berteotti changed the title WIP: feat[STK-33]: create stack frequency section feat[STK-33]: create stack frequency section Jul 14, 2023
@berteotti berteotti marked this pull request as ready for review July 14, 2023 16:15
@berteotti berteotti force-pushed the feat/stk-33-create-stacktimeframefrequency branch 2 times, most recently from 9c4ad28 to bd5f485 Compare July 14, 2023 18:25
@berteotti berteotti force-pushed the feat/stk-33-create-stacktimeframefrequency branch from bd5f485 to 847f809 Compare July 31, 2023 09:38
@Diogomartf
Copy link
Collaborator

Diogomartf commented Jul 31, 2023 •
edited
Loading

image

Design feedback

  • on the selected date button the ring should be primary-200 (or 300)
  • set date and time button should be primary action so it should be primary color, it's the main CTA (if not I forgot to click to save)
  • remove @ on the date (optional)
  • add back overlay to fade background colors.

@Diogomartf
Copy link
Collaborator

Diogomartf commented Jul 31, 2023 •
edited
Loading

1b9904e0b11b68c46cee0c1ab271b3d0.mp4

I selected a date in the future and if I change the frequency after it changes that date.

Isn't this behavior odd?

Diogomartf
Diogomartf previously approved these changes Aug 1, 2023
View reviewed changes
@berteotti berteotti force-pushed the feat/stk-33-create-stacktimeframefrequency branch from ca996e6 to 6996512 Compare August 1, 2023 13:39
@berteotti berteotti merged commit 016be7c into develop Aug 1, 2023
2 checks passed
@berteotti berteotti deleted the feat/stk-33-create-stacktimeframefrequency branch August 1, 2023 16:10
berteotti added a commit that referenced this pull request Oct 19, 2023
@berteotti
feat[STK-33]: create stack frequency section (#31)
d3ec1c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diogomartf Diogomartf Diogomartf approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berteotti @Diogomartf