Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][STK-259] -No image in Stackbox token icons #210

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: STK-259

Description

  • Removes an unneeded search param reset from our Network Context.
  • Removes an unwanted search params chain ID reset that was colliding with WAGMI's chain ID

Visual Evidence

Screenshot 2024-10-30 at 12 51 19

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stackly-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 2:06pm

@berteotti
Copy link
Collaborator

berteotti commented Oct 30, 2024

The problem here is that we are left with tokens that don't exist on the other chain, when we switch chain and have from and to token on the URL.

image

Copy link

cloudflare-workers-and-pages bot commented Oct 30, 2024

Deploying stackly-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: ad42497
Status: ✅  Deploy successful!
Preview URL: https://deecb98a.stackly-ui.pages.dev
Branch Preview URL: https://fix-stk-259-no-image-in-stac.stackly-ui.pages.dev

View logs

@ElRodrigote ElRodrigote merged commit ec9a13c into develop Oct 31, 2024
4 checks passed
@ElRodrigote ElRodrigote deleted the fix/stk-259-no-image-in-stackbox-token-icons branch October 31, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants