Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Creates env vars to handle our subgraph API endpoints #200

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

ElRodrigote
Copy link
Collaborator

Context

With this change we will be able to update our subgraph API endpoint URLs for the three supported chains, this way we will be able not to consume API credits for our development.

Description

  • Creates env vars to handle our subgraph API endpoints

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stackly-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 11:37am

Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just small improvements

packages/sdk/src/vaults/constants.ts Outdated Show resolved Hide resolved
packages/sdk/src/vaults/constants.ts Outdated Show resolved Hide resolved
packages/sdk/src/vaults/constants.ts Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Aug 19, 2024

Deploying stackly-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: c8fab88
Status: ✅  Deploy successful!
Preview URL: https://5d0bbadf.stackly-ui.pages.dev
Branch Preview URL: https://feat-create-subgraph-api-url.stackly-ui.pages.dev

View logs

const STACKLY_SUBGRAPH_API_KEY =
process.env.STACKLY_SUBGRAPH_API_KEY ?? "e7b7ff845e506590498946cd6bf83bf6";
const API_BASE_URL = "https://gateway-arbitrum.network.thegraph.com/api";
const SUBGRAPH_API_KEY = process.env.STACKLY_SUBGRAPH_API_KEY ?? "";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if don't set the SUBGRAPH_API_KEY key wouldn't be better to break?

@ElRodrigote ElRodrigote merged commit 6ddb80a into develop Aug 20, 2024
4 checks passed
@ElRodrigote ElRodrigote deleted the feat/create_subgraph_api_url_env_vars branch August 20, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants